Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user_assigned_identity: add state migration for ID casing #10196

Merged
merged 3 commits into from
Jan 18, 2021
Merged

user_assigned_identity: add state migration for ID casing #10196

merged 3 commits into from
Jan 18, 2021

Conversation

favoretti
Copy link
Collaborator

@favoretti favoretti commented Jan 15, 2021

Old user_assigned_identity are saved in the state with resourcegroups all in lowercase, forcing all resource that use it's .id property reference do a lowercasing dance every plan/apply.
This should fix the problem.

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @favoretti

Thanks for this PR :)

Taking a look through this mostly LGTM - if we can update the State Migration to parse the existing ID to account for one subtle bug then this should otherwise LGTM 👍

Thanks!

favoretti and others added 2 commits January 18, 2021 13:20
…_V0_to_V1.go

Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff
Copy link
Member

Tested locally looks good 👍

@tombuildsstuff tombuildsstuff merged commit a1a385d into hashicorp:master Jan 18, 2021
tombuildsstuff added a commit that referenced this pull request Jan 18, 2021
@ghost
Copy link

ghost commented Jan 21, 2021

This has been released in version 2.44.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.44.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Feb 18, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants