keyvault: optimising the lookup/adding a cache for Key Vaults #10330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eve it's name This avoids calling the `ListKeyVaults` API call by querying the resource list to locate this specific resource by it's identifier and type instead.
|
Tests pass:
|
jackofallops
approved these changes
Jan 27, 2021
There was a problem hiding this comment.
Thanks @tombuildsstuff - Couple of suggested changes for error messages while we're touching those lines anyway, but otherwise LGTM 👍
azurerm/internal/services/keyvault/key_vault_secret_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/keyvault/key_vault_secret_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/keyvault/key_vault_secret_resource.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Steve <11830746+jackofallops@users.noreply.github.com>
Co-authored-by: Steve <11830746+jackofallops@users.noreply.github.com>
Co-authored-by: Steve <11830746+jackofallops@users.noreply.github.com>
|
This has been released in version 2.45.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.45.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #7794 and #6866 and fixes #6196 by adding a cache for Key Vaults rather than listing these for each resource, which was intended as a short-term hack.
In addition this PR moves all of the Key Vault helpers to the
keyvault/clientpackage, meaning the locks can be private fields (and potentially reused in future if necessary).Notably this PR switches to looking the Key Vaults up using a filter on the Resources API to identify the Resource Group, meaning we're no longer pulling the entire list of Key Vaults in the subscription (originally necessary since it's not possible to retrieve a Key Vault without it's resource group directly)
Supersedes #7794
Supersedes #6866
Fixes #6196