-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_data_factory_linked_service_azure_blob_storage: various enhancements #10551
azurerm_data_factory_linked_service_azure_blob_storage: various enhancements #10551
Conversation
|
enhancements Fixes #10532
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @favoretti - Thanks for this PR, it's off to a good start. I've made some suggestions on how the schema could be made more easily read; and there's a couple of crashes that need to be addressed. If you can address those, I'll continue review and get the tests run.
Thanks again!
...erm/internal/services/datafactory/data_factory_linked_service_azure_blob_storage_resource.go
Outdated
Show resolved
Hide resolved
...erm/internal/services/datafactory/data_factory_linked_service_azure_blob_storage_resource.go
Outdated
Show resolved
Hide resolved
...erm/internal/services/datafactory/data_factory_linked_service_azure_blob_storage_resource.go
Outdated
Show resolved
Hide resolved
...erm/internal/services/datafactory/data_factory_linked_service_azure_blob_storage_resource.go
Outdated
Show resolved
Hide resolved
...erm/internal/services/datafactory/data_factory_linked_service_azure_blob_storage_resource.go
Outdated
Show resolved
Hide resolved
...erm/internal/services/datafactory/data_factory_linked_service_azure_blob_storage_resource.go
Outdated
Show resolved
Hide resolved
...erm/internal/services/datafactory/data_factory_linked_service_azure_blob_storage_resource.go
Outdated
Show resolved
Hide resolved
@jackofallops Thank you for your review. Feedback addressed. |
This has been released in version 2.49.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.49.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Add support for SAS URI; add Managed Identity and Service Princial auth
Fixes #10532