Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_data_factory_linked_service_azure_blob_storage: various enhancements #10551

Merged
merged 8 commits into from
Feb 25, 2021
Merged

azurerm_data_factory_linked_service_azure_blob_storage: various enhancements #10551

merged 8 commits into from
Feb 25, 2021

Conversation

favoretti
Copy link
Collaborator

@favoretti favoretti commented Feb 11, 2021

Add support for SAS URI; add Managed Identity and Service Princial auth

Fixes #10532

@favoretti
Copy link
Collaborator Author

$ TF_ACC=1 go test -v ./azurerm/internal/services/datafactory -timeout=1000m -run=TestAccDataFactoryLinkedServiceAzureBlobStorage_sas_uri
=== RUN   TestAccDataFactoryLinkedServiceAzureBlobStorage_sas_uri
=== PAUSE TestAccDataFactoryLinkedServiceAzureBlobStorage_sas_uri
=== CONT  TestAccDataFactoryLinkedServiceAzureBlobStorage_sas_uri
--- PASS: TestAccDataFactoryLinkedServiceAzureBlobStorage_sas_uri (115.94s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/datafactory	117.954s

$ TF_ACC=1 go test -v ./azurerm/internal/services/datafactory -timeout=1000m -run=TestAccDataFactoryLinkedServiceAzureBlobStorage_managed_id
=== RUN   TestAccDataFactoryLinkedServiceAzureBlobStorage_managed_id
=== PAUSE TestAccDataFactoryLinkedServiceAzureBlobStorage_managed_id
=== CONT  TestAccDataFactoryLinkedServiceAzureBlobStorage_managed_id
--- PASS: TestAccDataFactoryLinkedServiceAzureBlobStorage_managed_id (110.85s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/datafactory	112.404s

$ TF_ACC=1 go test -v ./azurerm/internal/services/datafactory -timeout=1000m -run=TestAccDataFactoryLinkedServiceAzureBlobStorage_basic
=== RUN   TestAccDataFactoryLinkedServiceAzureBlobStorage_basic
=== PAUSE TestAccDataFactoryLinkedServiceAzureBlobStorage_basic
=== CONT  TestAccDataFactoryLinkedServiceAzureBlobStorage_basic
--- PASS: TestAccDataFactoryLinkedServiceAzureBlobStorage_basic (106.82s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/datafactory	108.743s

@ghost ghost added size/XXL dependencies and removed size/XL labels Feb 11, 2021
@ghost ghost added size/XL and removed size/XXL labels Feb 11, 2021
@ghost ghost added size/L and removed size/XL labels Feb 11, 2021
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @favoretti - Thanks for this PR, it's off to a good start. I've made some suggestions on how the schema could be made more easily read; and there's a couple of crashes that need to be addressed. If you can address those, I'll continue review and get the tests run.

Thanks again!

@favoretti
Copy link
Collaborator Author

@jackofallops Thank you for your review. Feedback addressed.

@jackofallops jackofallops added this to the v2.49.0 milestone Feb 25, 2021
@jackofallops
Copy link
Member

Tests looking good:
image

@jackofallops jackofallops merged commit cbe7eae into hashicorp:master Feb 25, 2021
jackofallops added a commit that referenced this pull request Feb 25, 2021
@ghost
Copy link

ghost commented Feb 26, 2021

This has been released in version 2.49.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.49.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants