Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_api_management_subscription: make user_id optional #10638

Merged
merged 2 commits into from
Mar 18, 2021

Conversation

patst
Copy link
Contributor

@patst patst commented Feb 18, 2021

We want to create subscriptions per application. Therefore we don't want to assign a specific user to a subscription.

The details are described in #8923 .

make testacc TEST='./azurerm/internal/services/apimanagement/api_management_subscription_resource_test.go' TESTARGS='-run=TestAccApiManagementSubscription_complete' TESTTIMEOUT='120m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test ./azurerm/internal/services/apimanagement/api_management_subscription_resource_test.go -v -run=TestAccApiManagementSubscription_complete -timeout 120m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccApiManagementSubscription_complete
=== PAUSE TestAccApiManagementSubscription_complete
=== CONT  TestAccApiManagementSubscription_complete
--- PASS: TestAccApiManagementSubscription_complete (2601.34s)
PASS
ok      command-line-arguments  2602.981s

make testacc TEST='./azurerm/internal/services/apimanagement/api_management_subscription_resource_test.go' TESTARGS='-run=TestAccApiManagementSubscription_withoutUser' TESTTIMEOUT='120m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test ./azurerm/internal/services/apimanagement/api_management_subscription_resource_test.go -v -run=TestAccApiManagementSubscription_withoutUser -timeout 120m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccApiManagementSubscription_withoutUser
=== PAUSE TestAccApiManagementSubscription_withoutUser
=== CONT  TestAccApiManagementSubscription_withoutUser
--- PASS: TestAccApiManagementSubscription_withoutUser (2657.30s)
PASS
ok      command-line-arguments  2659.031s

Fixes #8923

add test for userless subscription
move SchemaApiManagementChildID to place where is used
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jackofallops
Copy link
Member

Tests looking fine, Failures are transient / unrelated:
image

@jackofallops jackofallops merged commit 4873c33 into hashicorp:master Mar 18, 2021
jackofallops added a commit that referenced this pull request Mar 18, 2021
@patst patst deleted the 8923-subscription-without-user branch March 18, 2021 11:56
@ghost
Copy link

ghost commented Mar 18, 2021

This has been released in version 2.52.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.52.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 17, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_api_management_subscription should not require product and user?!
3 participants