Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_batch_certificate: Allow empty password when format is pfx #10642

Merged

Conversation

austin-ek
Copy link
Contributor

When creating a batch certificate, the password is not required by the API and should not be required by the terraform provider. It is optional in other interfaces, such as ARM templates, REST API, and Azure CLI

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry changed the title Batch certificate: Allow no password when format is pfx azurerm_batch_certificate: Allow empty password when format is pfx Feb 19, 2021
@mbfrahry mbfrahry merged commit 6319303 into hashicorp:master Feb 19, 2021
mbfrahry added a commit that referenced this pull request Feb 19, 2021
@mbfrahry mbfrahry added this to the v2.49.0 milestone Feb 19, 2021
@ghost
Copy link

ghost commented Feb 26, 2021

This has been released in version 2.49.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.49.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 21, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants