Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_keyvault_secret: support versionless_id attribute #10738

Merged
merged 1 commit into from
Feb 26, 2021
Merged

azurerm_keyvault_secret: support versionless_id attribute #10738

merged 1 commit into from
Feb 26, 2021

Conversation

favoretti
Copy link
Collaborator

$ TF_ACC=1 go test -v ./azurerm/internal/services/keyvault -timeout=1000m -run=TestAccKeyVaultSecret_complete
2021/02/25 14:26:14 [DEBUG] not using binary driver name, it's no longer needed
2021/02/25 14:26:14 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccKeyVaultSecret_complete
=== PAUSE TestAccKeyVaultSecret_complete
=== CONT  TestAccKeyVaultSecret_complete
--- PASS: TestAccKeyVaultSecret_complete (286.29s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/keyvault	287.582s

Fixes #10736

```
$ TF_ACC=1 go test -v ./azurerm/internal/services/keyvault -timeout=1000m -run=TestAccKeyVaultSecret_complete
2021/02/25 14:26:14 [DEBUG] not using binary driver name, it's no longer needed
2021/02/25 14:26:14 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccKeyVaultSecret_complete
=== PAUSE TestAccKeyVaultSecret_complete
=== CONT  TestAccKeyVaultSecret_complete
--- PASS: TestAccKeyVaultSecret_complete (286.29s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/keyvault	287.582s
```

Fixes #10736
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry added this to the v2.50.0 milestone Feb 26, 2021
@mbfrahry mbfrahry changed the title azurerm_keyvault_secret: support versionless_id attribute azurerm_keyvault_secret: support versionless_id attribute Feb 26, 2021
@mbfrahry mbfrahry merged commit ac19140 into hashicorp:master Feb 26, 2021
mbfrahry added a commit that referenced this pull request Feb 26, 2021
@ghost
Copy link

ghost commented Mar 5, 2021

This has been released in version 2.50.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.50.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for versionless_id attribute for azurerm_key_vault_secret
2 participants