Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies: updating github.com/hashicorp/go-azure-helpers to v0.14.0 #10740

Merged
merged 2 commits into from
Feb 25, 2021

Conversation

tombuildsstuff
Copy link
Member

@tombuildsstuff tombuildsstuff commented Feb 25, 2021

This PR updates the following dependencies:

  • github.com/hashicorp/go-azure-helpers to v0.14.0
  • github.com/Azure/go-autorest/autorest to v0.11.18

Which fixes support for running in Azure CloudShell - and explicitly opts out of the Managed Identities support within the Azure SDK for App Service, App Service Environment and Function Apps, since these are intentionally not supported

Fixes #10292

@tombuildsstuff tombuildsstuff added this to the v2.49.0 milestone Feb 25, 2021
@tombuildsstuff tombuildsstuff requested a review from a team February 25, 2021 16:27
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit f673328 into master Feb 25, 2021
@tombuildsstuff tombuildsstuff deleted the deps/go-azure-helpers branch February 25, 2021 18:23
tombuildsstuff added a commit that referenced this pull request Feb 25, 2021
@ghost
Copy link

ghost commented Feb 26, 2021

This has been released in version 2.49.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.49.0"
}
# ... other configuration ...

@sharebear
Copy link
Contributor

@tombuildsstuff I saw this in the changelog... is it possible to get a little more detail on what is meant by the following

and explicitly opts out of the Managed Identities support within the Azure SDK for App Service, App Service Environment and Function Apps, since these are intentionally not supported

We use MSI in our CI pipeline for managing azurerm_app_service, azurerm_function_app and azurerm_app_service_plan resources, will these be affected by this change?

With no links to the upstream issues it's a little difficult to understand the impact based upon just the diff here :)

@tombuildsstuff
Copy link
Member Author

@sharebear

We use MSI in our CI pipeline for managing azurerm_app_service, azurerm_function_app and azurerm_app_service_plan resources, will these be affected by this change?

MSI itself is available in different environments (App Service/Function App, Containers, AKS, VM's etc) - what this is saying is the Azure Provider no longer supports being run inside of an App Service/Function App (since we never did, but this explicitly removes MSI as an option when running inside of an App Service/Function App, due to known issues) - your setup (from the sound of it using MSI within a VM/Container) is supported.

@sharebear
Copy link
Contributor

@tombuildsstuff Thanks for the clarification. Sounds like I'm good for my current setup.

@ghost
Copy link

ghost commented Mar 28, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure Cloud Shell Bash: Azure CLI authentication broken in azurerm v2.44.0
3 participants