Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_management_group - add validation to subscription_id list property #10948

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

jackofallops
Copy link
Member

@jackofallops jackofallops commented Mar 12, 2021

Resolves #10937

@ghost ghost added the size/XS label Mar 12, 2021
@jackofallops jackofallops changed the title azurerm_management_group - add validation to subscription_id list property azurerm_management_group - add validation to subscription_id list property Mar 12, 2021
@jackofallops jackofallops self-assigned this Mar 12, 2021
@jackofallops jackofallops requested a review from a team March 12, 2021 10:39
@jackofallops jackofallops added this to the v2.52.0 milestone Mar 12, 2021
@jackofallops
Copy link
Member Author

Tests looking good:
image

Copy link
Member

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jackofallops jackofallops merged commit b801757 into master Mar 12, 2021
@jackofallops jackofallops deleted the f/management-group-subscriptions-validation branch March 12, 2021 15:27
jackofallops added a commit that referenced this pull request Mar 12, 2021
@ghost
Copy link

ghost commented Mar 18, 2021

This has been released in version 2.52.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.52.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 12, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error create ManagementGroup with Subscription
2 participants