mssql: add resources azurerm_mssql_firewall_rule and azurerm_mssql_virtual_network_rule #10954
Conversation
…rtual_network_rule
manicminer
force-pushed
the
r/mssql-firewall
branch
from
14a3436
to
ac0f149
Compare
There was a problem hiding this comment.
Hi @manicminer - thanks for this, looks mostly good, just a couple minor changes noted below, otherwise LGTM 👍
| Importer: &schema.ResourceImporter{ | ||
| State: schema.ImportStatePassthrough, | ||
| }, |
There was a problem hiding this comment.
We should use ValidateResourceIDPriorToImport here.
| Importer: &schema.ResourceImporter{ | ||
| State: schema.ImportStatePassthrough, | ||
| }, | ||
|
|
There was a problem hiding this comment.
We should use the ValidateResourceIDPriorToImport here too.
|
Tests passing: |
|
This has been released in version 2.52.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.52.0"
}
# ... other configuration ... |
…rtual_network_rule (#10954) Co-authored-by: jackofallops <ste@hashicorp.com>
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
No description provided.