Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_hpc_cache - support for tags #11268

Merged
merged 2 commits into from Apr 13, 2021

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Apr 9, 2021

Fix #8117

Test Result

💤 TF_ACC=1 go test -v -timeout=2h ./azurerm/internal/services/hpccache -run=TestAccHPCCache_updateTags
2021/04/09 10:30:17 [DEBUG] not using binary driver name, it's no longer needed
2021/04/09 10:30:17 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccHPCCache_updateTags
=== PAUSE TestAccHPCCache_updateTags
=== CONT  TestAccHPCCache_updateTags
--- PASS: TestAccHPCCache_updateTags (1483.54s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/hpccache    1483.759s

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff added this to the v2.56.0 milestone Apr 13, 2021
@tombuildsstuff tombuildsstuff merged commit 2f9b31b into hashicorp:master Apr 13, 2021
tombuildsstuff added a commit that referenced this pull request Apr 13, 2021
@ghost
Copy link

ghost commented Apr 16, 2021

This has been released in version 2.56.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.56.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 13, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for tags within resource azurerm_hpc_cache
2 participants