-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: splitting the validators out into their own packages #11378
Conversation
7063d09
to
910a2c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I left a few comments on the import blocks of a few files but those aren't blocking.
azurerm/internal/services/databasemigration/database_migration_service_data_source.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/databasemigration/database_migration_service_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/hdinsight/hdinsight_hadoop_cluster_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/servicefabric/service_fabric_cluster_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/synapse/synapse_managed_private_endpoint_resource.go
Outdated
Show resolved
Hide resolved
910a2c3
to
4ea10b0
Compare
…r & setting tags into the state
4ea10b0
to
cdda970
Compare
This has been released in version 2.57.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.57.0"
}
# ... other configuration ... |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR splits the validators out from the Service Packages into the
validate
package, which is necessary to avoid a circular reference with the upcoming work to enable the Plugin SDK upgrade.