Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: splitting the validators out into their own packages #11378

Merged
merged 34 commits into from
Apr 21, 2021

Conversation

tombuildsstuff
Copy link
Member

This PR splits the validators out from the Service Packages into the validate package, which is necessary to avoid a circular reference with the upcoming work to enable the Plugin SDK upgrade.

@tombuildsstuff tombuildsstuff added this to the v2.57.0 milestone Apr 19, 2021
@ghost ghost added the size/XXL label Apr 19, 2021
@tombuildsstuff tombuildsstuff requested a review from a team April 20, 2021 09:41
Copy link
Member

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I left a few comments on the import blocks of a few files but those aren't blocking.

@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 2.57.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.57.0"
}
# ... other configuration ...

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants