Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_kubernetes_cluster: Add ingress_application_gateway_identity export for add-on ingress_application_gateway #11622

Merged

Conversation

aristosvo
Copy link
Collaborator

@aristosvo aristosvo commented May 7, 2021

Fixes #11564

Acceptance tests

  • New functionality tested and passing

    ❯ make acctests SERVICE='containers' TESTARGS='-run=TestAccKubernetesCluster_addonProfileIngressApplicationGateway_appGatewayId'
    ==> Checking that code complies with gofmt requirements...
    ==> Checking that Custom Timeouts are used...
    ==> Checking that acceptance test packages are used...
    TF_ACC=1 go test -v ./azurerm/internal/services/containers -run=TestAccKubernetesCluster_addonProfileIngressApplicationGateway_appGatewayId -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
    2021/05/07 18:15:43 [DEBUG] not using binary driver name, it's no longer needed
    2021/05/07 18:15:44 [DEBUG] not using binary driver name, it's no longer needed
    === RUN   TestAccKubernetesCluster_addonProfileIngressApplicationGateway_appGatewayId
    === PAUSE TestAccKubernetesCluster_addonProfileIngressApplicationGateway_appGatewayId
    === CONT  TestAccKubernetesCluster_addonProfileIngressApplicationGateway_appGatewayId
    --- PASS: TestAccKubernetesCluster_addonProfileIngressApplicationGateway_appGatewayId (1302.15s)
    PASS
    ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/containers    1306.024s
    
    ❯ make acctests SERVICE='containers' TESTARGS='-run=TestAccDataSourceKubernetesCluster_addOnProfileIngressApplicationGatewayAppGateway'
    ==> Checking that code complies with gofmt requirements...
    ==> Checking that Custom Timeouts are used...
    ==> Checking that acceptance test packages are used...
    TF_ACC=1 go test -v ./azurerm/internal/services/containers -run=TestAccDataSourceKubernetesCluster_addOnProfileIngressApplicationGatewayAppGateway -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
    2021/05/07 20:59:29 [DEBUG] not using binary driver name, it's no longer needed
    2021/05/07 20:59:30 [DEBUG] not using binary driver name, it's no longer needed
    === RUN   TestAccDataSourceKubernetesCluster_addOnProfileIngressApplicationGatewayAppGateway
    === PAUSE TestAccDataSourceKubernetesCluster_addOnProfileIngressApplicationGatewayAppGateway
    === CONT  TestAccDataSourceKubernetesCluster_addOnProfileIngressApplicationGatewayAppGateway
    --- PASS: TestAccDataSourceKubernetesCluster_addOnProfileIngressApplicationGatewayAppGateway (1341.64s)
    PASS
    ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/containers  1345.299s
    

@ghost ghost added the size/M label May 7, 2021
@ghost ghost added size/S and removed size/M labels May 7, 2021
@ghost ghost added size/M documentation and removed size/S labels May 7, 2021
@mbfrahry mbfrahry self-assigned this May 7, 2021
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @aristosvo! This looks mostly good minus a couple things I called out below! Thanks for taking the time to get this PR out

@aristosvo aristosvo force-pushed the feature/ingress-appgw-addon-identity branch from 7befe81 to 3de080c Compare May 7, 2021 19:54
@aristosvo
Copy link
Collaborator Author

Thanks @mbfrahry! Sorry to bother you with correcting my Friday night code 😅

I think this should do!

@aristosvo aristosvo requested a review from mbfrahry May 7, 2021 20:26
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries at all and LGTM! Thanks for taking care of that!

@mbfrahry mbfrahry changed the title kubernetes_cluster: Add identity export for add-on ingress_application_gateway azurerm_kubernetes_cluster: Add ingress_application_gateway_identity export for add-on ingress_application_gateway May 7, 2021
@mbfrahry mbfrahry added this to the v2.59.0 milestone May 7, 2021
@mbfrahry mbfrahry merged commit 308f1e6 into hashicorp:master May 7, 2021
mbfrahry added a commit that referenced this pull request May 7, 2021
@aristosvo aristosvo deleted the feature/ingress-appgw-addon-identity branch May 9, 2021 07:14
@ghost
Copy link

ghost commented May 14, 2021

This has been released in version 2.59.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.59.0"
}
# ... other configuration ...

favoretti pushed a commit to gro1m/terraform-provider-azurerm that referenced this pull request May 26, 2021
…ty` export for add-on `ingress_application_gateway` (hashicorp#11622)
favoretti pushed a commit to gro1m/terraform-provider-azurerm that referenced this pull request May 26, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2021
@aristosvo aristosvo restored the feature/ingress-appgw-addon-identity branch April 14, 2023 07:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ingress_application_gateway AKS addon should export managed identity properties
2 participants