Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_data_factory_linked_service_azure_sql_database: add key_vault_connection_string_property #12139

Merged
merged 1 commit into from
Jun 10, 2021
Merged

azurerm_data_factory_linked_service_azure_sql_database: add key_vault_connection_string_property #12139

merged 1 commit into from
Jun 10, 2021

Conversation

favoretti
Copy link
Collaborator

@favoretti favoretti commented Jun 9, 2021

$ TF_ACC=1 go test -v ./azurerm/internal/services/datafactory -timeout=1000m -run='TestAccDataFactoryLinkedServiceAzureSQLDatabase'
2021/06/09 11:53:35 [DEBUG] not using binary driver name, it's no longer needed
2021/06/09 11:53:35 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccDataFactoryLinkedServiceAzureSQLDatabase_basic
=== PAUSE TestAccDataFactoryLinkedServiceAzureSQLDatabase_basic
=== RUN   TestAccDataFactoryLinkedServiceAzureSQLDatabase_update
=== PAUSE TestAccDataFactoryLinkedServiceAzureSQLDatabase_update
=== RUN   TestAccDataFactoryLinkedServiceAzureSQLDatabase_managed_id
=== PAUSE TestAccDataFactoryLinkedServiceAzureSQLDatabase_managed_id
=== RUN   TestAccDataFactoryLinkedServiceAzureSQLDatabase_PasswordKeyVaultReference
=== PAUSE TestAccDataFactoryLinkedServiceAzureSQLDatabase_PasswordKeyVaultReference
=== RUN   TestAccDataFactoryLinkedServiceAzureSQLDatabase_ConnectionStringKeyVaultReference
=== PAUSE TestAccDataFactoryLinkedServiceAzureSQLDatabase_ConnectionStringKeyVaultReference
=== CONT  TestAccDataFactoryLinkedServiceAzureSQLDatabase_basic
=== CONT  TestAccDataFactoryLinkedServiceAzureSQLDatabase_ConnectionStringKeyVaultReference
=== CONT  TestAccDataFactoryLinkedServiceAzureSQLDatabase_PasswordKeyVaultReference
=== CONT  TestAccDataFactoryLinkedServiceAzureSQLDatabase_managed_id
=== CONT  TestAccDataFactoryLinkedServiceAzureSQLDatabase_update
--- PASS: TestAccDataFactoryLinkedServiceAzureSQLDatabase_managed_id (107.99s)
--- PASS: TestAccDataFactoryLinkedServiceAzureSQLDatabase_basic (120.47s)
--- PASS: TestAccDataFactoryLinkedServiceAzureSQLDatabase_update (165.46s)
--- PASS: TestAccDataFactoryLinkedServiceAzureSQLDatabase_PasswordKeyVaultReference (277.65s)
--- PASS: TestAccDataFactoryLinkedServiceAzureSQLDatabase_ConnectionStringKeyVaultReference (277.87s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/datafactory	279.235s

Actually fixes #10758, since previous PR closed it with something not totally related.

…ult_connection_string_property`

```
$ TF_ACC=1 go test -v ./azurerm/internal/services/datafactory -timeout=1000m -run='TestAccDataFactoryLinkedServiceAzureSQLDatabase'
2021/06/09 11:53:35 [DEBUG] not using binary driver name, it's no longer needed
2021/06/09 11:53:35 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccDataFactoryLinkedServiceAzureSQLDatabase_basic
=== PAUSE TestAccDataFactoryLinkedServiceAzureSQLDatabase_basic
=== RUN   TestAccDataFactoryLinkedServiceAzureSQLDatabase_update
=== PAUSE TestAccDataFactoryLinkedServiceAzureSQLDatabase_update
=== RUN   TestAccDataFactoryLinkedServiceAzureSQLDatabase_managed_id
=== PAUSE TestAccDataFactoryLinkedServiceAzureSQLDatabase_managed_id
=== RUN   TestAccDataFactoryLinkedServiceAzureSQLDatabase_PasswordKeyVaultReference
=== PAUSE TestAccDataFactoryLinkedServiceAzureSQLDatabase_PasswordKeyVaultReference
=== RUN   TestAccDataFactoryLinkedServiceAzureSQLDatabase_ConnectionStringKeyVaultReference
=== PAUSE TestAccDataFactoryLinkedServiceAzureSQLDatabase_ConnectionStringKeyVaultReference
=== CONT  TestAccDataFactoryLinkedServiceAzureSQLDatabase_basic
=== CONT  TestAccDataFactoryLinkedServiceAzureSQLDatabase_ConnectionStringKeyVaultReference
=== CONT  TestAccDataFactoryLinkedServiceAzureSQLDatabase_PasswordKeyVaultReference
=== CONT  TestAccDataFactoryLinkedServiceAzureSQLDatabase_managed_id
=== CONT  TestAccDataFactoryLinkedServiceAzureSQLDatabase_update
--- PASS: TestAccDataFactoryLinkedServiceAzureSQLDatabase_managed_id (107.99s)
--- PASS: TestAccDataFactoryLinkedServiceAzureSQLDatabase_basic (120.47s)
--- PASS: TestAccDataFactoryLinkedServiceAzureSQLDatabase_update (165.46s)
--- PASS: TestAccDataFactoryLinkedServiceAzureSQLDatabase_PasswordKeyVaultReference (277.65s)
--- PASS: TestAccDataFactoryLinkedServiceAzureSQLDatabase_ConnectionStringKeyVaultReference (277.87s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/datafactory	279.235s
```
@ghost ghost added size/M labels Jun 9, 2021
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry added this to the v2.63.0 milestone Jun 10, 2021
@mbfrahry mbfrahry merged commit 0522261 into hashicorp:master Jun 10, 2021
mbfrahry added a commit that referenced this pull request Jun 10, 2021
@ghost
Copy link

ghost commented Jun 11, 2021

This has been released in version 2.63.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.63.0"
}
# ... other configuration ...

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for secrets in key vault for azurerm_data_factory_linked_service_azure_sql_database
2 participants