Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Service/App Service Slots - adding support for min TLS version #1601

Merged

Conversation

phekmat
Copy link
Contributor

@phekmat phekmat commented Jul 18, 2018

  • Add support for the minimum TLS version used for clients connecting to
    an app service or slot
  • Add tests for app service and slot resources, data source, and import

- Add support for the minimum TLS version used for clients connecting to
an app service or slot
- Add tests for app service and slot resources, data source, and import
@phekmat phekmat force-pushed the feature/app_service_min_tls branch from 32eb440 to 483142e Compare July 19, 2018 15:09
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this 👍

@tombuildsstuff
Copy link
Member

Data Source tests pass:

screenshot 2018-07-21 at 19 32 21

Resource tests pass:

screenshot 2018-07-21 at 19 41 44

@tombuildsstuff tombuildsstuff changed the title Add support for min TLS version for app services and slots App Service/App Service Slots - adding support for min TLS version Jul 21, 2018
@tombuildsstuff tombuildsstuff merged commit dcd80ee into hashicorp:master Jul 21, 2018
tombuildsstuff added a commit that referenced this pull request Jul 21, 2018
@tombuildsstuff tombuildsstuff added this to the 1.11.0 milestone Jul 21, 2018
@alex-3sr
Copy link

Hi,

Is it possible to add min_tls_version for azurerm_function_app too ?

Thanks,
Regards

@ghost
Copy link

ghost commented Jun 27, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants