Auto Scale: filter out the $tags tag
#1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change (with the acctest fix): ``` $ acctests azurerm TestAccAzureRMAutoScaleSetting_basic === RUN TestAccAzureRMAutoScaleSetting_basic --- FAIL: TestAccAzureRMAutoScaleSetting_basic (400.30s) testing.go:513: Step 0 error: Check failed: Check 7/7 error: azurerm_autoscale_setting.test: Attribute 'tags.$type' found when not expected FAIL FAIL github.com/terraform-providers/terraform-provider-azurerm/azurerm 400.721s ``` Now: ``` $ acctests azurerm TestAccAzureRMAutoScaleSetting_basic === RUN TestAccAzureRMAutoScaleSetting_basic --- PASS: TestAccAzureRMAutoScaleSetting_basic (399.98s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm 400.321s ```
bflad
approved these changes
Aug 15, 2018
| @@ -432,7 +432,9 @@ func resourceArmAutoScaleSettingRead(d *schema.ResourceData, meta interface{}) e | |||
| return fmt.Errorf("Error setting `notification` of Autoscale Setting %q (resource group %q): %+v", name, resourceGroup, err) | |||
| } | |||
|
|
|||
| flattenAndSetTags(d, resp.Tags) | |||
| // Return a new tag map filtered by the specified tag names. | |||
| tagMap := filterTags(resp.Tags, "$type") | |||
There was a problem hiding this comment.
Should this filtering be applied more globally? There seems to have been a few issues related to it across various resources.
There was a problem hiding this comment.
Not necessarily unfortunately - this values only restricted in certain API's (read: Monitor/App Insights) - such that it's potentially a valid key in other API's
|
Tests pass:
|
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change (with the acctest fix contained in this PR):
Now:
Fixes #1661