Use filter for azuread_service_principal and azuread_application data sources #1862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the objects that match the data source query.
tiwood
changed the title
tombuildsstuff
suggested changes
Sep 6, 2018
There was a problem hiding this comment.
hey @tiwood
Thanks for this PR - I've taken a look through and this mostly LGTM, if we can fix up the (minor) comments we should be able to run the tests and get this merged :)
Thanks!
tiwood
commented
Sep 7, 2018
|
Tests pass:
|
tombuildsstuff
added a commit
that referenced
this pull request
Sep 7, 2018
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1844
This adds a filter to the ListAll() method to limit the results that are returned by the API to only include objects that match the data source query.