Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Role Definition: support for Data Actions #1971

Merged
merged 2 commits into from
Sep 27, 2018

Conversation

tombuildsstuff
Copy link
Member

$ acctests azurerm TestAccAzureRMRoleDefinition_complete
=== RUN   TestAccAzureRMRoleDefinition_complete
--- PASS: TestAccAzureRMRoleDefinition_complete (46.46s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	47.349s

Fixes #1538

```
$ acctests azurerm TestAccAzureRMRoleDefinition_complete
=== RUN   TestAccAzureRMRoleDefinition_complete
--- PASS: TestAccAzureRMRoleDefinition_complete (46.46s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	47.349s
```

Fixes #1538
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern here is that both fields should IMO be TypeSet since ordering is not significant.

I don't know the API's behaviour but I worry that the current implementation would cause spurious diffs, hence I'm making it a blocker, although I understand this may need fixing in other places too.

@ghost ghost added the size/S label Sep 26, 2018
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming relevant acceptance tests are passing

@tombuildsstuff
Copy link
Member Author

Ignoring an existing failing test - the tests pass:

screenshot 2018-09-27 at 10 33 24

@tombuildsstuff tombuildsstuff merged commit d7811a3 into master Sep 27, 2018
@tombuildsstuff tombuildsstuff deleted the f/role-definition/data-actions branch September 27, 2018 00:34
tombuildsstuff added a commit that referenced this pull request Sep 27, 2018
@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants