Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_application_gateway: Adding override backend path support #2879

Merged
merged 6 commits into from
Feb 14, 2019
Merged

azurerm_application_gateway: Adding override backend path support #2879

merged 6 commits into from
Feb 14, 2019

Conversation

ghostinthewires
Copy link
Contributor

This PR introduces the ability to support the override backend path setting in Application Gateway (requested in #1760)

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @ghostinthewires

Thanks for this PR :)

Taking a look through this mostly LGTM - if we can update the naming of the field to better match the API then this should be good to merge 👍

Thanks!

azurerm/resource_arm_application_gateway.go Outdated Show resolved Hide resolved
@ghostinthewires
Copy link
Contributor Author

Hi, Do you need any further changes by me on this or is it now good to merge?

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @ghostinthewires

Thanks for pushing those changes - this now LGTM - I'll kick off the tests shortly 👍

Thanks!

@tombuildsstuff
Copy link
Member

Tests pass - thanks for this @ghostinthewires

screenshot 2019-02-14 at 19 11 24

@tombuildsstuff tombuildsstuff merged commit ac5d46b into hashicorp:master Feb 14, 2019
tombuildsstuff added a commit that referenced this pull request Feb 14, 2019
@ghostinthewires
Copy link
Contributor Author

Great, thanks.

I assume this means #1760 can now be closed?

@ghost
Copy link

ghost commented Mar 8, 2019

This has been released in version 1.23.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.23.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 17, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants