Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_cdn_endpoint - defaulting the http_port and https_port #301

Merged
merged 1 commit into from
Sep 1, 2017

Conversation

tombuildsstuff
Copy link
Member

As discovered by @changeworld in #288 - it appears http_port and https_port should be being defaulted to 80 and 443. From what I can tell this was previously done at the API - but are now mandatory parameters.

Also fixes the original documentation issue discovered in #288

Tests pass:

$ acctests azurerm TestAccAzureRMCdnEndpoint
=== RUN   TestAccAzureRMCdnEndpoint_importWithTags
--- PASS: TestAccAzureRMCdnEndpoint_importWithTags (185.24s)
=== RUN   TestAccAzureRMCdnEndpoint_basic
--- PASS: TestAccAzureRMCdnEndpoint_basic (166.18s)
=== RUN   TestAccAzureRMCdnEndpoint_disappears
--- PASS: TestAccAzureRMCdnEndpoint_disappears (179.67s)
=== RUN   TestAccAzureRMCdnEndpoint_updateHostHeader
--- PASS: TestAccAzureRMCdnEndpoint_updateHostHeader (196.97s)
=== RUN   TestAccAzureRMCdnEndpoint_withTags
--- PASS: TestAccAzureRMCdnEndpoint_withTags (193.53s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	921.610s

Copy link
Contributor

@grubernaut grubernaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tombuildsstuff tombuildsstuff merged commit dda0aaf into master Sep 1, 2017
tombuildsstuff added a commit that referenced this pull request Sep 1, 2017
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants