Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application gateway WAF upload file size limit is set to 0 by default #3011

Closed
uritau opened this issue Mar 6, 2019 · 2 comments
Closed

Comments

@uritau
Copy link

uritau commented Mar 6, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform (and AzureRM Provider) Version

Latest

Affected Resource(s)

  • azurerm_application_gateway
    More specific: in the waf configuration block upload file size limit (file_upload_limit_mb)

Expected Behavior

If Application gateway WAF upload file size limit is not set, the default value must be 100. (file_upload_limit_mb).

From the documentation:

file_upload_limit_mb - (Optional) The File Upload Limit in MB. Accepted values are in the range 1MB to 500MB. Defaults to 100MB.

Actual Behavior

The Application Gateway it's deployed with a 0 as file size limit.
Theorically, the size limit (from Azure documentation) goes from 1 to 100 (or 500) Mb.
But, in fact, it's possible to define as 0, and it seems that, by default, Terraform is setting it to this value.

Steps to Reproduce

  1. Deploy without specifiying file_upload_limit_mb.
  2. Check the upload file max size allowed, (You can check it uploading a file (even small than 1 Mb) and it will block you.)

References

https://www.terraform.io/docs/providers/azurerm/r/application_gateway.html
https://docs.microsoft.com/en-us/azure/application-gateway/application-gateway-waf-configuration

  • #0000
@tombuildsstuff
Copy link
Contributor

Fixed via #3012

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants