Support for Active Directory User Credentials #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombuildsstuff
force-pushed
the
azurecli-auth
branch
from
0c3b7a0
to
3053ec7
Compare
tombuildsstuff
force-pushed
the
azurecli-auth
branch
from
3053ec7
to
266c733
Compare
tombuildsstuff
force-pushed
the
azurecli-auth
branch
from
266c733
to
7d5a54c
Compare
tombuildsstuff
changed the title
mbfrahry
approved these changes
Sep 14, 2017
azurerm/provider.go
Outdated
| continue | ||
| } | ||
|
|
||
| // TODO: replace this with something that's not terrible |
There was a problem hiding this comment.
Will this TODO happen in this PR?
There was a problem hiding this comment.
Nope - I can't find a better way of doing this (as such I've removed it for the moment)
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterThis is dependent on Azure/go-autorest#169. MergedFixes #42