Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/storage_share: switching to use the new storage sdk #3828

Merged
merged 8 commits into from
Jul 11, 2019

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Jul 11, 2019

This PR switches over the azurerm_storage_share resource over to using the new Storage SDK, so that we can add new resources & remove the older resources. I believe that this should also fix #2384

The new functionality will be added in a subsequent PR, now that this has been switched over

Fixes #2384

@tombuildsstuff
Copy link
Contributor Author

Tests pass:

Screenshot 2019-07-11 at 13 46 09

@ghost ghost added the documentation label Jul 11, 2019
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tombuildsstuff tombuildsstuff merged commit bcaffac into master Jul 11, 2019
@tombuildsstuff tombuildsstuff deleted the f/storage-share branch July 11, 2019 17:37
tombuildsstuff added a commit that referenced this pull request Jul 12, 2019
@ghost
Copy link

ghost commented Jul 30, 2019

This has been released in version 1.32.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.32.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Aug 11, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot check existence of an azurerm_storage_share
2 participants