Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/storage_table: switching over to using the new sdk #3834

Merged
merged 2 commits into from
Jul 12, 2019

Conversation

tombuildsstuff
Copy link
Contributor

$ acctests azurerm TestAccAzureRMStorageTable_
=== RUN   TestAccAzureRMStorageTable_basic
=== PAUSE TestAccAzureRMStorageTable_basic
=== RUN   TestAccAzureRMStorageTable_requiresImport
--- SKIP: TestAccAzureRMStorageTable_requiresImport (0.00s)
    resource_arm_storage_table_test.go:46: Skipping since resources aren't required to be imported
=== RUN   TestAccAzureRMStorageTable_disappears
=== PAUSE TestAccAzureRMStorageTable_disappears
=== CONT  TestAccAzureRMStorageTable_basic
--- PASS: TestAccAzureRMStorageTable_basic (117.02s)
=== CONT  TestAccAzureRMStorageTable_disappears
--- PASS: TestAccAzureRMStorageTable_disappears (103.54s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	220.621s

```
$ acctests azurerm TestAccAzureRMStorageTable_
=== RUN   TestAccAzureRMStorageTable_basic
=== PAUSE TestAccAzureRMStorageTable_basic
=== RUN   TestAccAzureRMStorageTable_requiresImport
--- SKIP: TestAccAzureRMStorageTable_requiresImport (0.00s)
    resource_arm_storage_table_test.go:46: Skipping since resources aren't required to be imported
=== RUN   TestAccAzureRMStorageTable_disappears
=== PAUSE TestAccAzureRMStorageTable_disappears
=== CONT  TestAccAzureRMStorageTable_basic
--- PASS: TestAccAzureRMStorageTable_basic (117.02s)
=== CONT  TestAccAzureRMStorageTable_disappears
--- PASS: TestAccAzureRMStorageTable_disappears (103.54s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	220.621s
```
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with just some minor error message changes

azurerm/resource_arm_storage_table.go Outdated Show resolved Hide resolved
azurerm/resource_arm_storage_table_test.go Outdated Show resolved Hide resolved
azurerm/resource_arm_storage_table_test.go Outdated Show resolved Hide resolved
azurerm/resource_arm_storage_table_test.go Outdated Show resolved Hide resolved
azurerm/resource_arm_storage_table.go Outdated Show resolved Hide resolved
azurerm/resource_arm_storage_table.go Outdated Show resolved Hide resolved
Co-Authored-By: Matthew Frahry <mbfrahry@gmail.com>
@tombuildsstuff tombuildsstuff merged commit 8f1950f into master Jul 12, 2019
@tombuildsstuff tombuildsstuff deleted the f/storage-table branch July 12, 2019 16:02
tombuildsstuff added a commit that referenced this pull request Jul 12, 2019
@ghost
Copy link

ghost commented Jul 30, 2019

This has been released in version 1.32.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.32.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Aug 12, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants