azurerm_storage_account - fixes #302
#421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge Account with `ZRS` redundancy Fixes #302
|
Tests still pass:
|
tombuildsstuff
requested review from
vancluever
and removed request for
mbfrahry
vancluever
suggested changes
Oct 12, 2017
| @@ -253,6 +253,10 @@ func resourceArmStorageAccountCreate(d *schema.ResourceData, meta interface{}) e | |||
|
|
|||
| // AccessTier is only valid for BlobStorage accounts | |||
| if accountKind == string(storage.BlobStorage) { | |||
| if string(parameters.Sku.Name) == string(storage.StandardZRS) { | |||
There was a problem hiding this comment.
Would this check be needed in Update too as account_replication_type is not ForceNew?
There was a problem hiding this comment.
good point, most of the Azure resources are CreateOrUpdate - so I'd assumed this was the same - I'll update it now..
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning a user friendly error when trying to provision a Blob Storage Account with
ZRSredundancyFixes #302