Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: azurerm_keyvault_certificate extended_key_usage cras… #4272

Merged
merged 1 commit into from
Sep 6, 2019

Conversation

mbfrahry
Copy link
Member

@mbfrahry mbfrahry commented Sep 6, 2019

Addressing #4259 and adding defensive logic for expanding a string slice

@ghost ghost added the size/M label Sep 6, 2019
Copy link
Contributor

@tracypholmes tracypholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mbfrahry! LGTM, but where are the test results? 😄

@tracypholmes tracypholmes added this to the v1.34.0 milestone Sep 6, 2019
@tracypholmes tracypholmes changed the title Bug Fix: azurerm_keyvault_certificate extended_key_usage crash fix Bug Fix: azurerm_keyvault_certificate extended_key_usage cras… Sep 6, 2019
@tracypholmes tracypholmes merged commit 57bd8e0 into master Sep 6, 2019
@tracypholmes tracypholmes deleted the b-keyvault-cert-crash branch September 6, 2019 23:00
tracypholmes added a commit that referenced this pull request Sep 6, 2019
@ghost
Copy link

ghost commented Sep 18, 2019

This has been released in version 1.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.34.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants