Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analysis services server server_full_name & backup_blob_container_uri #4397

Conversation

r0bnet
Copy link
Contributor

@r0bnet r0bnet commented Sep 20, 2019

Added new read-only field: server_full_name
Added new field for making backup of the analysis services server: backup_blob_container_uri

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor comment but this otherwise LGTM - thanks for this @r0bnet :)

azurerm/resource_arm_analysis_services_server.go Outdated Show resolved Hide resolved
@tombuildsstuff tombuildsstuff added this to the v1.35.0 milestone Sep 26, 2019
r0bnet and others added 2 commits September 26, 2019 10:44
Co-Authored-By: Tom Harvey <tombuildsstuff@users.noreply.github.com>
@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2019-09-26 at 11 40 16

@tombuildsstuff tombuildsstuff merged commit 9677b2f into hashicorp:master Sep 26, 2019
tombuildsstuff added a commit that referenced this pull request Sep 26, 2019
@r0bnet r0bnet deleted the analysis_services_server-backup-blob-container branch September 30, 2019 12:38
@ghost
Copy link

ghost commented Oct 4, 2019

This has been released in version 1.35.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.35.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants