Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/storage_blob: making metadata a computed field #4727

Merged
merged 1 commit into from
Oct 28, 2019

Conversation

tombuildsstuff
Copy link
Contributor

Fixes:

------- Stdout: -------
=== RUN   TestAccAzureRMVirtualMachine_basicLinuxMachine_storageBlob_attach
=== PAUSE TestAccAzureRMVirtualMachine_basicLinuxMachine_storageBlob_attach
=== CONT  TestAccAzureRMVirtualMachine_basicLinuxMachine_storageBlob_attach
--- FAIL: TestAccAzureRMVirtualMachine_basicLinuxMachine_storageBlob_attach (537.62s)
    testing.go:569: Step 2 error: After applying this step and refreshing, the plan was not empty:

        DIFF:

        UPDATE: azurerm_storage_blob.test
          access_tier:                                 "" => ""
          attempts:                                    "1" => "1"
          content_type:                                "application/octet-stream" => "application/octet-stream"
          id:                                          "https://accsa191025142503682006.blob.core.windows.net/vhds/datadisk1.vhd" => "https://accsa191025142503682006.blob.core.windows.net/vhds/datadisk1.vhd"
          metadata.microsoftazurecompute_diskid:       "8c06f7b0-a629-404c-9c5a-4906d4b74e50" => ""
          metadata.microsoftazurecompute_diskname:     "datadisk1.vhd" => ""
          metadata.microsoftazurecompute_disksizeingb: "45" => ""
          metadata.microsoftazurecompute_disktype:     "DataDisk" => ""
          metadata.microsoftazurecompute_vmname:       "acctvm-191025142503682006" => ""
          name:                                        "datadisk1.vhd" => "datadisk1.vhd"
          parallelism:                                 "8" => "8"
          resource_group_name:                         "acctestRG-191025142503682006" => "acctestRG-191025142503682006"
          size:                                        "0" => "0"
          source_uri:                                  "https://accsa191025142503682006.blob.core.windows.net/vhds/myosdisk1.vhd" => "https://accsa191025142503682006.blob.core.windows.net/vhds/myosdisk1.vhd"
          storage_account_name:                        "accsa191025142503682006" => "accsa191025142503682006"
          storage_container_name:                      "vhds" => "vhds"
          type:                                        "Page" => "Page"
          url:                                         "https://accsa191025142503682006.blob.core.windows.net/vhds/datadisk1.vhd" => "https://accsa191025142503682006.blob.core.windows.net/vhds/datadisk1.vhd"

Fixes:

```
------- Stdout: -------
=== RUN   TestAccAzureRMVirtualMachine_basicLinuxMachine_storageBlob_attach
=== PAUSE TestAccAzureRMVirtualMachine_basicLinuxMachine_storageBlob_attach
=== CONT  TestAccAzureRMVirtualMachine_basicLinuxMachine_storageBlob_attach
--- FAIL: TestAccAzureRMVirtualMachine_basicLinuxMachine_storageBlob_attach (537.62s)
    testing.go:569: Step 2 error: After applying this step and refreshing, the plan was not empty:

        DIFF:

        UPDATE: azurerm_storage_blob.test
          access_tier:                                 "" => ""
          attempts:                                    "1" => "1"
          content_type:                                "application/octet-stream" => "application/octet-stream"
          id:                                          "https://accsa191025142503682006.blob.core.windows.net/vhds/datadisk1.vhd" => "https://accsa191025142503682006.blob.core.windows.net/vhds/datadisk1.vhd"
          metadata.microsoftazurecompute_diskid:       "8c06f7b0-a629-404c-9c5a-4906d4b74e50" => ""
          metadata.microsoftazurecompute_diskname:     "datadisk1.vhd" => ""
          metadata.microsoftazurecompute_disksizeingb: "45" => ""
          metadata.microsoftazurecompute_disktype:     "DataDisk" => ""
          metadata.microsoftazurecompute_vmname:       "acctvm-191025142503682006" => ""
          name:                                        "datadisk1.vhd" => "datadisk1.vhd"
          parallelism:                                 "8" => "8"
          resource_group_name:                         "acctestRG-191025142503682006" => "acctestRG-191025142503682006"
          size:                                        "0" => "0"
          source_uri:                                  "https://accsa191025142503682006.blob.core.windows.net/vhds/myosdisk1.vhd" => "https://accsa191025142503682006.blob.core.windows.net/vhds/myosdisk1.vhd"
          storage_account_name:                        "accsa191025142503682006" => "accsa191025142503682006"
          storage_container_name:                      "vhds" => "vhds"
          type:                                        "Page" => "Page"
          url:                                         "https://accsa191025142503682006.blob.core.windows.net/vhds/datadisk1.vhd" => "https://accsa191025142503682006.blob.core.windows.net/vhds/datadisk1.vhd"
```
@tombuildsstuff tombuildsstuff added this to the v1.36.0 milestone Oct 25, 2019
@tombuildsstuff tombuildsstuff requested a review from a team October 25, 2019 15:01
@ghost ghost added the size/XS label Oct 25, 2019
@tombuildsstuff
Copy link
Contributor Author

VM Test passes:

Screenshot 2019-10-25 at 17 01 57

@tombuildsstuff
Copy link
Contributor Author

Blob tests pass:

Screenshot 2019-10-25 at 18 05 54

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tombuildsstuff tombuildsstuff merged commit 2bddcab into master Oct 28, 2019
@tombuildsstuff tombuildsstuff deleted the b/storage-blob-metadata branch October 28, 2019 05:00
tombuildsstuff added a commit that referenced this pull request Oct 28, 2019
@ghost
Copy link

ghost commented Oct 29, 2019

This has been released in version 1.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.36.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 27, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants