Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_app_service_slot: auto_swap_slot_name support #4752

Merged
merged 1 commit into from
Oct 30, 2019

Conversation

phekmat
Copy link
Contributor

@phekmat phekmat commented Oct 29, 2019

Add auto_swap_slot_name to the azurerm_app_service_slot resource's
site_config. This attribute enables auto-swapping to another slot
(e.g. the production slot) during deployment

Add `auto_swap_slot_name` to the `azurerm_app_service_slot` resource's
`site_config`. This attribute enables auto-swapping to another slot
(e.g. the production slot) during deployment
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry
Copy link
Member

Thanks for this @phekmat. Changes look good and should make it into the next release

@mbfrahry mbfrahry changed the title Add auto swap slot name for azurerm_app_service_slot azurerm_app_service_slot: auto_swap_slot_name support Oct 30, 2019
@mbfrahry mbfrahry merged commit 9af3600 into hashicorp:master Oct 30, 2019
@mbfrahry mbfrahry added this to the v1.37.0 milestone Oct 30, 2019
@ghost
Copy link

ghost commented Nov 26, 2019

This has been released in version 1.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.37.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 29, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants