Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: upgrading Azure/azure-sdk-for-go and hashicorp/go-azure-helpers #4775

Merged
merged 4 commits into from
Nov 1, 2019

Conversation

tombuildsstuff
Copy link
Contributor

This PR updates the following dependencies:

  • github.com/Azure/azure-sdk-for-go to v35.0.0
  • github.com/Azure/go-autorest to v0.9.2
  • github.com/hashicorp/go-azure-helpers to v0.10.0

The upgrade to hashicorp/go-azure-helpers includes the fix for #2602 which introduces a custom refresh function; allowing us to shell out to the Azure CLI for a replacement refresh token.

Once this PR is merged the documentation for Azure CLI authentication also needs to be updated to clarify that running longer-running tasks should be done via a Service Principal; since the refresh token itself can have custom expiry depending on the GPO's configured on the AAD Tenant (or, for example a password expiring).

Fixes #2602

@tombuildsstuff tombuildsstuff added this to the v1.37.0 milestone Oct 31, 2019
@tombuildsstuff tombuildsstuff self-assigned this Oct 31, 2019
@ghost ghost added the size/XXL label Oct 31, 2019
@tombuildsstuff
Copy link
Contributor Author

Storage (Container) tests pass:

Screenshot 2019-10-31 at 13 35 57

@tombuildsstuff
Copy link
Contributor Author

Acceptance Test results for this look the same as master 👍

@tombuildsstuff tombuildsstuff requested a review from a team November 1, 2019 06:57
@tombuildsstuff tombuildsstuff changed the title [WIP] Dependencies: upgrading Azure/azure-sdk-for-go and hashicorp/go-azure-helpers Dependencies: upgrading Azure/azure-sdk-for-go and hashicorp/go-azure-helpers Nov 1, 2019
Copy link
Contributor

@tracypholmes tracypholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tombuildsstuff tombuildsstuff merged commit e84f00e into master Nov 1, 2019
@tombuildsstuff tombuildsstuff deleted the d/dependencies branch November 1, 2019 16:06
tombuildsstuff added a commit that referenced this pull request Nov 1, 2019
@ghost
Copy link

ghost commented Nov 26, 2019

This has been released in version 1.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.37.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting an intermittent failed to refresh Bearer token error when trying to delete my AKS cluster
2 participants