Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fqdn attribute for DNS record resources #5000

Merged
merged 5 commits into from
Nov 27, 2019
Merged

Add fqdn attribute for DNS record resources #5000

merged 5 commits into from
Nov 27, 2019

Conversation

aqche
Copy link
Contributor

@aqche aqche commented Nov 27, 2019

Fixes: #4391

Adds the fqdn attribute for all DNS record resources.

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @aqche

@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2019-11-27 at 11 14 26

@tombuildsstuff tombuildsstuff merged commit 3e2d984 into hashicorp:master Nov 27, 2019
tombuildsstuff added a commit that referenced this pull request Nov 27, 2019
@aqche aqche deleted the dns_record_fqdn branch November 27, 2019 16:45
@ghost
Copy link

ghost commented Dec 7, 2019

This has been released in version 1.38.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.38.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Dec 27, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Dec 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_dns_a_record/azurerm_dns_cname_record to export FQDN
3 participants