Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: query keys for azure search #5029

Merged

Conversation

allantargino
Copy link
Contributor

fixes #5028

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @allantargino

Thanks for this PR - apologies for the delayed review here!

Taking a look through this mostly LGTM - since I've only left a couple of minor comments in-line I hope you don't mind but I'm going to push a commit to resolve that so that we can get this merged 👍

Thanks!

website/docs/r/search_service.html.markdown Outdated Show resolved Hide resolved
website/docs/r/search_service.html.markdown Outdated Show resolved Hide resolved
@tombuildsstuff tombuildsstuff removed their assignment Dec 17, 2019
@tombuildsstuff
Copy link
Contributor

@allantargino hope you don't mind but I've also rebased this since this was needed; apologies again for the delay reviewing this!

@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2019-12-17 at 23 41 46

@tombuildsstuff tombuildsstuff merged commit ba3c352 into hashicorp:master Dec 17, 2019
tombuildsstuff added a commit that referenced this pull request Dec 17, 2019
@allantargino
Copy link
Contributor Author

hi @tombuildsstuff !
No problems at all! Actually, thank you for reviewing it and also fixing all problems!

@ghost
Copy link

ghost commented Jan 8, 2020

This has been released in version 1.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.40.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
@allantargino allantargino deleted the search-service-query-keys branch January 2, 2021 15:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Azure Search query keys
2 participants