Fix product api not reassigned on manual delete

[sschne]

fixes #5002

Due to behaviour changes in Azure apimanagement API, HTTP 404 response code was not considered an error in version 2018-01-01 and is now considered an error in 2019-01-01. To fix the behavior in the currently used API version, we need to also check for ResponseWasNotFound, when the CheckEntityExists produces no error.

[tnicolaysen]

I made a PR #5096 for upgrading. Care to have a look? I think it needs review. I've done some basic testing myself, but it would be nice to gain some confidence from someone else testing it.

[tombuildsstuff]

hey @pather87

Thanks for this PR - apologies for the delayed review here!

Taking a look through this LGTM - I'll kick off the test suite now 👍

Thanks!

[tombuildsstuff]

Tests pass:

[ghost]

This has been released in version 1.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.40.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!