Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create 'iothub_dps_shared_access_policy' resource #5171

Merged
merged 4 commits into from
Dec 18, 2019

Conversation

jackbatzner
Copy link
Contributor

Create the 'azurerm_iothub_dps_shared_access_policy' resource.

Fixes #4822.

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @Brunhil

Thanks for this PR :)

I've taken a look through and left some comments inline but this is mostly looking good to me; so that we can get this merged I hope you don't mind but I'm going to push a commit to resolve these - but this otherwise LGTM 👍

Thanks!

azurerm/resource_arm_iothub_dps_shared_acess_policy.go Outdated Show resolved Hide resolved
azurerm/resource_arm_iothub_dps_shared_acess_policy.go Outdated Show resolved Hide resolved
azurerm/resource_arm_iothub_dps_shared_acess_policy.go Outdated Show resolved Hide resolved
azurerm/resource_arm_iothub_dps_shared_acess_policy.go Outdated Show resolved Hide resolved
azurerm/resource_arm_iothub_dps_shared_acess_policy.go Outdated Show resolved Hide resolved
@tombuildsstuff
Copy link
Member

Tests pass:

Screenshot 2019-12-18 at 16 33 45

@tombuildsstuff tombuildsstuff merged commit 0847d19 into hashicorp:master Dec 18, 2019
tombuildsstuff added a commit that referenced this pull request Dec 18, 2019
@jackbatzner
Copy link
Contributor Author

Thanks @tombuildsstuff ! Slowly starting to get the hang of this Go and TF Provider magic 😄

@ghost
Copy link

ghost commented Jan 8, 2020

This has been released in version 1.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.40.0"
}
# ... other configuration ...

@jackbatzner jackbatzner deleted the add_iot_dps_sap branch March 14, 2020 14:48
@ghost
Copy link

ghost commented Mar 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_iot_dps missing ability to provide AuthorizationPolicies
2 participants