Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/virtual_network_gateway: support for configuring generation #5198

Merged
merged 7 commits into from
Dec 18, 2019

Conversation

phires
Copy link
Contributor

@phires phires commented Dec 17, 2019

Fix for #5173 (support virtual network gateway generation)

Fixes #5173

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @phires

Thanks for this PR :)

Taking a look through this mostly LGTM - if we can fix up the minor comments this should otherwise be good to merge 👍

Thanks!

azurerm/resource_arm_virtual_network_gateway.go Outdated Show resolved Hide resolved
azurerm/resource_arm_virtual_network_gateway.go Outdated Show resolved Hide resolved
azurerm/resource_arm_virtual_network_gateway.go Outdated Show resolved Hide resolved
azurerm/data_source_virtual_network_gateway.go Outdated Show resolved Hide resolved
website/docs/d/virtual_network_gateway.html.markdown Outdated Show resolved Hide resolved
website/docs/r/virtual_network_gateway.html.markdown Outdated Show resolved Hide resolved
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @phires

Thanks for pushing those changes - running the tests identified a bug around the default value for generation - as such I hope you don't mind but so that we can get this merged I've pushed a couple of commits to fix this, and this now LGTM 👍

Thanks!

@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2019-12-18 at 07 36 20

@tombuildsstuff tombuildsstuff changed the title Vpngw gen r/virtual_network_gateway: support for configuring generation Dec 18, 2019
@tombuildsstuff tombuildsstuff merged commit 145a7fd into hashicorp:master Dec 18, 2019
tombuildsstuff added a commit that referenced this pull request Dec 18, 2019
@phires phires deleted the vpngw-gen branch December 18, 2019 08:28
@ghost
Copy link

ghost commented Jan 8, 2020

This has been released in version 1.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.40.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Generation 2 virtual network gateways
2 participants