azurerm_*_virtual_machine_scale_set - upgrade_mode="Automatic" no longer requires health probe
#6667
Conversation
There was a problem hiding this comment.
hey @bacicrajko
Thanks for this PR - apologies for the delayed review here!
Taking a look through this LGTM - I'll kick off the test suite now 👍
Thanks!
azurerm/internal/services/compute/linux_virtual_machine_scale_set_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/compute/windows_virtual_machine_scale_set_resource.go
Outdated
Show resolved
Hide resolved
...erm/internal/services/compute/tests/windows_virtual_machine_scale_set_other_resource_test.go
Show resolved
Hide resolved
mbfrahry
changed the title
azurerm_*_virtual_machine_scale_set - upgrade_mode="Automatic" no longer requires health probe
|
Thanks for this @bacicrajko! We'll get it into the next release |
|
This has been released in version 2.25.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.25.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Hello, this fixes #6545
Setting the upgrade mode to Automatic does not necessarily require health probe to be also set. health probe becomes required if any of the options within automatic_os_upgrade_policy are also set