Add support for Azure Policy Assignment metadata

[tyconsulting]

Resolves #7724 Add support for specifying meta data for Azure Policy Assignments. Same as Azure Policy Definitions, metadata is also supported by Policy Assignment in ARM. Currently, the azure_policy_assignment in azurerm provider (v2.18.0) does not support metadata as an input.

[tyconsulting]

Feature Request: #7724

[ArcturusZhang]

Hi @tyconsulting thanks for this PR!

This PR looks great to me, aside from some minor comments that I have left inline, please have a look, thanks!

[tombuildsstuff]

hey @tyconsulting

Thanks for this PR :)

Taking a look through here this is looking good, if we can add this new field to the documentation (and fix the linting error) then this otherwise LGTM 👍

Thanks!

[tyconsulting]

hey @tyconsulting

Thanks for this PR :)

Taking a look through here this is looking good, if we can add this new field to the documentation (and fix the linting error) then this otherwise LGTM 👍

Thanks!

Hi @tombuildsstuff thanks for getting back to me. i've updated the documentation. however, I'm struggling to find the error identified by tflint. when I ran "terrafmt fmt -f ./azurerm/internal/services/policy/tests/policy_assignment_resource_test.go -v", the output is:
./azurerm/internal/services/policy/tests/policy_assignment_resource_test.go: 606 lines & formatted 0/8 blocks!

It didn't update anything. Could you please check for me and let me know exactly where I need to change? thanks.

[ArcturusZhang]

Hi @tyconsulting thanks for the revisions!

There are two minor format inline comments, please have a look.

And as for the terrafmt, I just run

terrafmt fmt -f .\azurerm\internal\services\policy\tests\policy_assignment_resource_test.go

and it works fine, you could have a try (without -v). Or you could try make terrafmt which would also works (but it may take a long time to run)

[ArcturusZhang]

Thanks @tyconsulting for the revisions, now LGTM 👍

[jackofallops]

Hi @tyconsulting
Thanks for this. I've taken a quick run though your changes and I've added a couple of comments that will need addressing before we can merge.

Thanks again!

[jackofallops]

Tests passing:

[ghost]

This has been released in version 2.19.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.19.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!