Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_storage_account - support static_website for BlockBlobStorage account type #7890

Merged
merged 2 commits into from
Aug 7, 2020
Merged

Conversation

DavidSimner
Copy link
Contributor

Microsoft Azure supports static_website for BlockBlobStorage and so this PR adds support for this into terraform-provider-azurerm

image

@ghost ghost added the size/XS label Jul 24, 2020
@DavidSimner
Copy link
Contributor Author

Hi @magodo any chance of a code review on this PR?

@magodo
Copy link
Collaborator

magodo commented Aug 6, 2020

Hey @DavidSimner Thank you for this PR! It almost LGTM 👍
If we can add some test and update the document to reflect this change, then it is good to merge!

@DavidSimner
Copy link
Contributor Author

@magodo are you happy to add a test and update the docs, or would you like me to? If me, then could you please give me a few pointers to where the relevant tests and docs are? Thanks :)

@magodo
Copy link
Collaborator

magodo commented Aug 6, 2020

Hi @DavidSimner

You might want to add a test case to test against static_web works for the BlockBlobStorage, similar to this one. Also, you will need to mention that in the document here.

Otherwise, I can also do the change for you if you don't mind to check the box to allow edits from maintainer.

@DavidSimner
Copy link
Contributor Author

If you can make the change then that would great! I've given you access I think :)

@magodo

This comment has been minimized.

@DavidSimner

This comment has been minimized.

@ghost ghost added size/M documentation and removed size/XS labels Aug 7, 2020
@magodo magodo changed the title Support static_website for BlockBlobStorage azurerm_storage_account - Support static_website for BlockBlobStorage account type Aug 7, 2020
@magodo magodo added this to the v2.23.0 milestone Aug 7, 2020
@magodo
Copy link
Collaborator

magodo commented Aug 7, 2020

@DavidSimner I have made a commit on top of your branch to add the test and document. It LGTM now!

@magodo magodo merged commit 4eb061b into hashicorp:master Aug 7, 2020
@magodo magodo changed the title azurerm_storage_account - Support static_website for BlockBlobStorage account type azurerm_storage_account - support static_website for BlockBlobStorage account type Aug 7, 2020
magodo added a commit that referenced this pull request Aug 7, 2020
update CHANGELOG.md for #7890
magodo added a commit that referenced this pull request Aug 7, 2020
Fix a typo of last commit...
@DavidSimner DavidSimner deleted the patch-1 branch August 7, 2020 07:07
@ghost
Copy link

ghost commented Aug 13, 2020

This has been released in version 2.23.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.23.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Sep 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants