Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_container_group - add support for volume.x.git_repo #7924

Merged
merged 3 commits into from
Oct 26, 2020

Conversation

njuCZ
Copy link
Contributor

@njuCZ njuCZ commented Jul 28, 2020

fix #7875

@njuCZ njuCZ closed this Jul 28, 2020
@njuCZ njuCZ reopened this Jul 28, 2020
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @njuCZ. This is nearly there, we just need to add some additional checks to ensure we create the volume correctly

AzureFile: &containerinstance.AzureFileVolume{
}

if gitRepoVolume := expandGitRepoVolume(volumeConfig["git_repo"].([]interface{})); gitRepoVolume != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to do some logic to make sure that either git_repo is specified or the share name/storage account information is specified. We'll also want to check that both aren't specified. The last check will be that all the share name and storage account information is specified if git_repo isn't specified. If one of those checks fail, we'll need to raise that error for the user.

@njuCZ
Copy link
Contributor Author

njuCZ commented Oct 26, 2020

@mbfrahry I have added some validation, and all acctest could pass, Could you have a look again when free?

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry added this to the v2.34.0 milestone Oct 26, 2020
@mbfrahry mbfrahry changed the title add support for git repo volume - "azurerm_container_group" azurerm_container_group - add support for volume.x.git_repo Oct 26, 2020
@mbfrahry mbfrahry merged commit 00590bb into hashicorp:master Oct 26, 2020
mbfrahry added a commit that referenced this pull request Oct 26, 2020
@ghost
Copy link

ghost commented Oct 29, 2020

This has been released in version 2.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.34.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for azurerm_container_group - mounting a Git repo to a container instance.
3 participants