Azure Policy: 'mode' shouldn't force new Policy

[logachev]

It is possible to change Azure Policy Mode (All\Indexed) via the portal for existing policy, so it doesn't required ForceNew when changed.

Testing:
Deployed the policy & changed mode multiple times. Changes were reflected via the Azure Portal

provider "azurerm" {
    features{}
}

resource "azurerm_policy_definition" "policy" {
  name         = "accTestPolicy"
  policy_type  = "Custom"
  mode         = "Indexed"
  display_name = "acceptance test policy definition"

  metadata = <<METADATA
    {
    "category": "General"
    }

METADATA


  policy_rule = <<POLICY_RULE
    {
    "if": {
      "not": {
        "field": "location",
        "in": "[parameters('allowedLocations')]"
      }
    },
    "then": {
      "effect": "audit"
    }
  }
POLICY_RULE


  parameters = <<PARAMETERS
    {
    "allowedLocations": {
      "type": "Array",
      "metadata": {
        "description": "The list of allowed locations for resources.",
        "displayName": "Allowed locations",
        "strongType": "location"
      }
    }
  }
PARAMETERS
}

[ArcturusZhang]

Hi @logachev thanks for this PR!

While this looks great to me, could you please add one test case for this? For instance, a test case that change the mode from All to Indexed and then back to All.

Also could you also please change the doc page - removing the Changing this resource forces a new resource to be created. statement?

[logachev]

@ArcturusZhang thanks for the feedback! Update this PR with new acceptance test & documentation change.

[ArcturusZhang]

LGTM 👍 thanks @logachev

[tombuildsstuff]

LGTM 👍

[tombuildsstuff]

Tests pass:

[ghost]

This has been released in version 2.24.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.24.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!