-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use API version 2020-03-01 for Loadbalancer #8006
Use API version 2020-03-01 for Loadbalancer #8006
Conversation
Can someone please review this? Load balancers have been broken for more than a month now |
@magodo is this one on your radar based on our Slack conversation? |
@marc-sensenich Yes, I have looked through this PR and it LGTM, thanks 👍 While downgrading API version needs some thoughts and tests, I am discussing with other maintainers for their opinions on this PR. In the meanwhile, we have some fix in the new Go SDK for the LB issue and trying hard to integrate into terraform azurerm provider. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for this / apologies for the delay here @marc-sensenich
This has been released in version 2.24.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.24.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Closes #7691 by using the 2020-03-01 network API version. Based off a comment by @tombuildsstuff from #7741 as this issue is present on more than just
azurerm_lb_rule
deletionThe reason for that issue is that service can't tolerate the client sending properties.backendAddressPools.n.properties.backendIPConfigurations in request body for load balancer resource since 2020-05-01, as it is a READ-ONLY attribute (this only occurs when azurerm_lb's sku is Standard).
Currently, Azure Go SDK can trim the READ-ONLY attributes during marshaling, but only for the root level attributes, so, in this case, Go SDK will still marshal the attribute into the request body. This is tracked in issue: Azure/autorest.go#438.
Acceptance Tests