Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use API version 2020-03-01 for Loadbalancer #8006

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Use API version 2020-03-01 for Loadbalancer #8006

merged 1 commit into from
Aug 19, 2020

Conversation

marc-sensenich
Copy link
Contributor

@marc-sensenich marc-sensenich commented Aug 4, 2020

Closes #7691 by using the 2020-03-01 network API version. Based off a comment by @tombuildsstuff from #7741 as this issue is present on more than just azurerm_lb_rule deletion

The reason for that issue is that service can't tolerate the client sending properties.backendAddressPools.n.properties.backendIPConfigurations in request body for load balancer resource since 2020-05-01, as it is a READ-ONLY attribute (this only occurs when azurerm_lb's sku is Standard).
Currently, Azure Go SDK can trim the READ-ONLY attributes during marshaling, but only for the root level attributes, so, in this case, Go SDK will still marshal the attribute into the request body. This is tracked in issue: Azure/autorest.go#438.

Acceptance Tests

--- PASS: TestAccAzureRMLoadBalancer_standard (74.84s)
--- PASS: TestAccAzureRMLoadBalancer_requiresImport (126.75s)
--- PASS: TestAccAzureRMLoadBalancerRule_disappears (136.04s)
--- PASS: TestAccAzureRMLoadBalancerBackEndAddressPool_basic (140.11s)
--- PASS: TestAccAzureRMLoadBalancerRule_updateMultipleRules (211.43s)
--- PASS: TestAccAzureRMLoadBalancerRule_removal (211.44s)
--- PASS: TestAccAzureRMLoadBalancer_basic (136.61s)
--- PASS: TestAccAzureRMLoadBalancerRule_inconsistentReads (211.45s)
--- PASS: TestAccAzureRMLoadBalancerProbe_basic (321.01s)
--- PASS: TestAccAzureRMLoadBalancer_frontEndConfigPublicIPPrefix (132.72s)
--- PASS: TestAccAzureRMLoadBalancerRule_complete (147.61s)
--- PASS: TestAccAzureRMLoadBalancerProbe_update (341.34s)
--- PASS: TestAccAzureRMLoadBalancerRule_basic (137.91s)
--- PASS: TestAccAzureRMLoadBalancerProbe_requiresImport (169.84s)
--- PASS: TestAccAzureRMLoadBalancerProbe_disappears (392.64s)
--- PASS: TestAccAzureRMLoadBalancerProbe_removal (202.78s)
--- PASS: TestAccAzureRMLoadBalancerProbe_updateProtocol (389.76s)
--- PASS: TestAccAzureRMLoadBalancerRule_update (1464.92s)
--- PASS: TestAccAzureRMLoadBalancerNatPool_removal (1194.92s)
--- PASS: TestAccAzureRMLoadBalancerRule_requiresImport (1464.96s)
--- PASS: TestAccAzureRMLoadBalancer_privateIP (1179.42s)
--- PASS: TestAccAzureRMLoadBalancer_emptyPrivateIP (1157.00s)
--- PASS: TestAccAzureRMLoadBalancerNatRule_basic (1152.61s)
--- PASS: TestAccAzureRMLoadBalancerNatRule_complete (1162.42s)
--- PASS: TestAccAzureRMLoadBalancer_tags (1196.95s)
--- PASS: TestAccAzureRMLoadBalancerOutboundRule_disappears (94.63s)
--- PASS: TestAccAzureRMLoadBalancerOutboundRule_requiresImport (105.37s)
--- PASS: TestAccAzureRMLoadBalancerNatPool_requiresImport (145.97s)
--- PASS: TestAccAzureRMLoadBalancerNatPool_disappears (149.86s)
--- PASS: TestAccAzureRMLoadBalancerBackEndAddressPool_disappears (156.94s)
--- PASS: TestAccAzureRMLoadBalancerNatPool_update (173.39s)
--- PASS: TestAccAzureRMLoadBalancer_frontEndConfig (213.04s)
--- PASS: TestAccAzureRMLoadBalancerOutboundRule_basic (119.46s)
--- PASS: TestAccAzureRMLoadBalancerNatPool_basic (137.47s)
--- PASS: TestAccAzureRMLoadBalancerNatRule_update (192.43s)
--- PASS: TestAccAzureRMLoadBalancerNatRule_disappears (137.54s)
--- PASS: TestAccAzureRMLoadBalancerOutboundRule_update (118.24s)
--- PASS: TestAccAzureRMLoadBalancerOutboundRule_withPublicIPPrefix (164.61s)
--- PASS: TestAccAzureRMLoadBalancerNatRule_updateMultipleRules (193.30s)
--- PASS: TestAccAzureRMLoadBalancerNatRule_removal (171.90s)
--- PASS: TestAccAzureRMLoadBalancerNatRule_requiresImport (180.32s)
--- PASS: TestAccAzureRMLoadBalancerOutboundRule_removal (201.86s)
--- PASS: TestAccAzureRMLoadBalancerBackEndAddressPool_requiresImport (181.10s)
--- PASS: TestAccAzureRMLoadBalancerBackEndAddressPool_removal (226.18s)

@hbuckle
Copy link
Contributor

hbuckle commented Aug 13, 2020

Can someone please review this? Load balancers have been broken for more than a month now

@marc-sensenich
Copy link
Contributor Author

@magodo is this one on your radar based on our Slack conversation?

@magodo
Copy link
Collaborator

magodo commented Aug 15, 2020

@marc-sensenich Yes, I have looked through this PR and it LGTM, thanks 👍

While downgrading API version needs some thoughts and tests, I am discussing with other maintainers for their opinions on this PR. In the meanwhile, we have some fix in the new Go SDK for the LB issue and trying hard to integrate into terraform azurerm provider.

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this / apologies for the delay here @marc-sensenich

@tombuildsstuff
Copy link
Member

Tests pass:

Screenshot 2020-08-19 at 11 02 28

@tombuildsstuff tombuildsstuff merged commit 0ede7d5 into hashicorp:master Aug 19, 2020
tombuildsstuff added a commit that referenced this pull request Aug 19, 2020
@ghost
Copy link

ghost commented Aug 20, 2020

This has been released in version 2.24.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.24.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Sep 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.18.0 - Error removing/updating load balancer rules
4 participants