frontdoor: refactoring & ensuring ID's are consistent #8146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombuildsstuff
added
bug
upstream/microsoft
|
Tests pass:
|
jackofallops
approved these changes
Aug 18, 2020
There was a problem hiding this comment.
Hi @tombuildsstuff - A few minor comments, but otherwise LGTM 👍
azurerm/internal/services/frontdoor/frontdoor_firewall_policy_resource.go
Outdated
Show resolved
Hide resolved
Also fixing issues where fields aren't set into the state to ensure that fields always have a value
…king the wrong resource name
…precating `resource_group_name`
…ect case at import time
tombuildsstuff
force-pushed
the
f/frontdoor-ids
branch
from
07b3253
to
75223f4
Compare
tombuildsstuff
added a commit
that referenced
this pull request
Aug 19, 2020
|
This has been released in version 2.24.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.24.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces quite a large refactoring to the Frontdoor resources - namely this ensures that all fields are always set - and ensures that ID's are consistent, so that users can rely on these.
Supersedes #8046
Fixes #8036