Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty ip_addresses list for azurerm_application_gateway (#8209) #8210

Merged
merged 2 commits into from
Aug 24, 2020
Merged

Allow empty ip_addresses list for azurerm_application_gateway (#8209) #8210

merged 2 commits into from
Aug 24, 2020

Conversation

simonbrady
Copy link
Contributor

@simonbrady simonbrady commented Aug 23, 2020

Fix and testcase for #8209

fixes #8209

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor comment but this otherwise LGTM - thanks @simonbrady 👍

@simonbrady
Copy link
Contributor Author

Thanks for the quick feedback @tombuildsstuff , your suggestion's much cleaner so PR updated.

@ghost ghost removed the waiting-response label Aug 24, 2020
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for pushing that change @simonbrady 👍

@tombuildsstuff
Copy link
Member

Tests pass:

Screenshot 2020-08-24 at 08 54 54

@tombuildsstuff tombuildsstuff merged commit 739fa45 into hashicorp:master Aug 24, 2020
tombuildsstuff added a commit that referenced this pull request Aug 24, 2020
@ghost
Copy link

ghost commented Aug 27, 2020

This has been released in version 2.25.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.25.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Sep 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_application_gateway doesn't allow empty backend IP list
2 participants