Support graceful Linux/Windows VM shutdown #8470
Conversation
ghost
added
|
hi @jstachowiak - just passing through and noticed you've included the changelog in this PR. Maintainers update that when we merge PR's so it's accurate and current for the release that the change goes into, so we'll need you to remove that change please. |
|
Cool @jackofallops! I removed that change and added a few acceptance tests. Some jobs failed with the following error: I can see the tag, so I assume it's a glitch. How can I rerun these jobs? |
There was a problem hiding this comment.
hey @jstachowiak
Thanks for this PR :)
Taking a look through this is off to a good start - but since this is a behavioural feature toggle it'd be good to move this to the features block within the provider block to group the behavioural feature toggles together - could we update this?
Thanks!
azurerm/internal/services/compute/linux_virtual_machine_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/compute/tests/linux_virtual_machine_resource_other_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/compute/tests/linux_virtual_machine_resource_other_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/compute/tests/linux_virtual_machine_resource_other_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/compute/tests/linux_virtual_machine_resource_other_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/compute/tests/windows_virtual_machine_resource_other_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/compute/tests/windows_virtual_machine_resource_other_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/compute/tests/windows_virtual_machine_resource_other_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/compute/tests/windows_virtual_machine_resource_other_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/compute/windows_virtual_machine_resource.go
Outdated
Show resolved
Hide resolved
|
Hi @tombuildsstuff! I implemented the changes that you requested. |
|
@tombuildsstuff, do you have time to take look at my changes? |
|
Hi @tombuildsstuff, any update here? 🤔 |
|
@jstachowiak apologies for the delay, missed this - will take a look now 👍 |
There was a problem hiding this comment.
hey @jstachowiak
Thanks for pushing those changes - apologies for the delayed re-review here!
I've taken a look through and left one comment inline around wording - but if we can fix that and rebase this PR on top of master then this should otherwise be good to merge 👍
Thanks!
Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
|
Thanks @tombuildsstuff - this was fun! 🚀 |
|
Acceptance Tests look good 👍 |
|
This has been released in version 2.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.37.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Closes #8469