Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azurerm_policy_set_definition - Fix updates for parameters and parameter_values #8882

Conversation

ArcturusZhang
Copy link
Contributor

Fixes #8880

@ghost ghost added the size/XL label Oct 14, 2020
@jackofallops jackofallops changed the title Update azurerm_policy_set_definition - Fixes #8880 Update azurerm_policy_set_definition - Fix updates for parameters and parameter_values Oct 14, 2020
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ArcturusZhang - Thanks for this PR, Looking good so far. I've made a suggestion on one item below, and there's a couple lint/test issues in travis to look at. I'll loop back once you've updated for those to continue review.

@ArcturusZhang
Copy link
Contributor Author

Hi @jackofallops I make some changes, please have a look, thanks

@ghost ghost added the documentation label Oct 19, 2020
@ArcturusZhang
Copy link
Contributor Author

Hi @jackofallops I also change the JSON object statement in docs to JSON string to reduce misleading (for instance reported in this issue)

@jackofallops jackofallops added this to the v2.33.0 milestone Oct 19, 2020
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ArcturusZhang - LGTM now 👍

@jackofallops
Copy link
Member

Tests Passing (2 failures unrelated)
image

@jackofallops jackofallops merged commit 3762bba into hashicorp:master Oct 19, 2020
jackofallops added a commit that referenced this pull request Oct 19, 2020
@ArcturusZhang ArcturusZhang deleted the fix-yet-another-issue-on-policy-set-definition branch October 19, 2020 23:31
@ghost
Copy link

ghost commented Oct 22, 2020

This has been released in version 2.33.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.33.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_policy_set_definition reports error during update
2 participants