Upgrade containerservice API to 2020-09-01

[favoretti]

In prep for #8657

[favoretti]

Fixing acceptance tests atm, will take a few more days I think...

[favoretti]

@tombuildsstuff I think now we should be ready to review this.

[tombuildsstuff]

hey @favoretti

Thanks for this PR - apologies for the delayed review here.

As discussed offline, I was hoping to dig in deeper into these comments today to be able to confirm the migration path (e.g. if we should rip these out, since they're no longer usable due to the breaking change on the AKS API side - or if we should keep them supported and deprecated for now, raising an error if the fields specified).

Unfortunately I didn't get a chance to do that today - but generally speaking we'd tend to deprecate this field, and then remove it in 3.0 - rather than ripping this out and introducing a breaking config change - to follow the semantic versioning rules here (the best we can, anyway). What that means is introducing a "DeprecationMessage" to the items in the schema to raise the deprecation alert in the Terraform CLI - and an error during creation for the Pod Security Policy which can no longer be configured, if that's set to true - what do you think?

Thanks!

[favoretti]

Hey @tombuildsstuff, thank you for the review! Committed your suggestions, will work on deprecation tomorrow/monday.

[favoretti]

@tombuildsstuff resolved everything but 2 things, will try to catch you on slack tomorrow to talk about those, not really sure what to do about them.

[tombuildsstuff]

hey @favoretti

Thanks for pushing those changes - taking a look through, aside from one minor comment this otherwise LGTM 👍

Thanks!

[tombuildsstuff]

As discussed offline - the "addOnProfile" blocks are intentionally failing (both in master and this branch) due to a behavioural difference between Azure Public and other Azure Environments - where the Kubernetes Dashboard is enabled by default in Azure Public up until Kubernetes 1.18/1.19 (at which point it's no longer available), but isn't available (at all) in some other Azure Environments (China, USGovernment). As such whilst it's unfortunate these tests fail, it's required to be able to covers these scenarios when using different versions of AKS in different Azure Environments - but the resource itself works fine 👍

[tombuildsstuff]

LGTM 👍

[tombuildsstuff]

Ignoring some intentionally failing tests for the "AddOnProfile", due to the behaviour of AKS in Azure Public - and one temporary AKS failure the tests otherwise look good:

[ghost]

This has been released in version 2.35.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.35.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!