Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/key_vault: ensuring the casing on the sku is consistent #8983

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

tombuildsstuff
Copy link
Member

Matching the SKU Casing with what the SDK expects.

Supersedes #8467
Fixes #8457

Matching the SKU Casing with what the SDK expects. Fixes #8457
@tombuildsstuff
Copy link
Member Author

Tests pass:

Screenshot 2020-10-22 at 14 18 25

Copy link
Member

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@manicminer manicminer merged commit dd12c8b into master Oct 23, 2020
@manicminer manicminer deleted the b/key-vault-sku branch October 23, 2020 08:29
manicminer added a commit that referenced this pull request Oct 23, 2020
@ghost
Copy link

ghost commented Oct 29, 2020

This has been released in version 2.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.34.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 22, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect casing for SKU name values when importing azurerm_key_vault
2 participants