Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for secret volumes in azurerm_container_group #9117

Merged
merged 4 commits into from Nov 19, 2020
Merged

Add support for secret volumes in azurerm_container_group #9117

merged 4 commits into from Nov 19, 2020

Conversation

Sbou
Copy link
Contributor

@Sbou Sbou commented Nov 2, 2020 •
edited

resolves #5585

@Sbou Sbou changed the title Add suuport for secret volumes in azurerm_container_group Add support for secret volumes in azurerm_container_group Nov 2, 2020
@Sbou Sbou mentioned this pull request Nov 9, 2020
Closed
@tombuildsstuff tombuildsstuff added this to the v2.37.0 milestone Nov 17, 2020
@tombuildsstuff tombuildsstuff requested review from tombuildsstuff and a team and removed request for tombuildsstuff November 17, 2020 11:29
@jackofallops
Copy link
Member

Hi @Sbou - Hope you don't mind, I've pushed a couple minor wording changes rather than requesting them so we can merge this for today's release.

jackofallops
jackofallops approved these changes Nov 19, 2020
View reviewed changes
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Sbou - This LGTM 👍

@jackofallops
Copy link
Member

Tests looking good:
image

@manicminer manicminer merged commit 6cb530a into hashicorp:master Nov 19, 2020
manicminer added a commit that referenced this pull request Nov 19, 2020
@manicminer
Update changelog for #9117
4ea209a
@ghost
Copy link

ghost commented Nov 20, 2020

This has been released in version 2.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.37.0"
}
# ... other configuration ...

@Sbou Sbou deleted the f/container-group-volume branch November 20, 2020 08:13
@ghost
Copy link

ghost commented Dec 20, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked as resolved and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackofallops jackofallops jackofallops approved these changes

Assignees
No one assigned
Labels
documentation enhancement service/container-group size/M
Projects
None yet
Milestone
v2.37.0
Development

Successfully merging this pull request may close these issues.

Support for secret volumes in azurerm_container_group
4 participants
@Sbou @jackofallops @manicminer @tombuildsstuff