Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_key_vault_access_policy - check access policy consistency before committing to state #9125

Merged
merged 5 commits into from
Nov 4, 2020

Conversation

jackofallops
Copy link
Member

fixes #9107

@jackofallops jackofallops added this to the v2.35.0 milestone Nov 2, 2020
@jackofallops jackofallops self-assigned this Nov 2, 2020
@ghost ghost added the size/XL label Nov 2, 2020
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM 👍


if _, err := stateConf.WaitForState(); err != nil {
return fmt.Errorf("failed waiting for Key Vault Access Policy (Object ID: %q) to apply: %+v", objectId, err)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(as discussed offline) this likely wants adding to the key vault resource's update function, too - to ensure that's covered from this edge-case too?

@jackofallops
Copy link
Member Author

Tests passing:
image

@jackofallops jackofallops merged commit 001bd5c into master Nov 4, 2020
@jackofallops jackofallops deleted the b/keyvault-permissions branch November 4, 2020 15:08
jackofallops added a commit that referenced this pull request Nov 4, 2020
@ghost
Copy link

ghost commented Nov 5, 2020

This has been released in version 2.35.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.35.0"
}
# ... other configuration ...

rukawata added a commit to Azure/sap-hana that referenced this pull request Nov 5, 2020
rukawata added a commit to Azure/sap-hana that referenced this pull request Nov 5, 2020
rukawata added a commit to Azure/sap-hana that referenced this pull request Nov 5, 2020
rukawata added a commit to Azure/sap-hana that referenced this pull request Nov 5, 2020
rukawata added a commit to Azure/sap-hana that referenced this pull request Nov 5, 2020
rukawata added a commit to Azure/sap-hana that referenced this pull request Nov 5, 2020
rukawata added a commit to Azure/sap-hana that referenced this pull request Nov 5, 2020
rukawata added a commit to Azure/sap-hana that referenced this pull request Nov 5, 2020
rukawata added a commit to Azure/sap-hana that referenced this pull request Nov 5, 2020
@ghost
Copy link

ghost commented Dec 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Unauthorized" error when creating azurerm_key_vault_secret while checking for secret existence in v2.34
2 participants