Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proximity_placement_group_id to AKS node pools #9195

Merged
merged 13 commits into from
Nov 12, 2020
Merged

Add proximity_placement_group_id to AKS node pools #9195

merged 13 commits into from
Nov 12, 2020

Conversation

favoretti
Copy link
Collaborator

Fixes #9164

(make fmt reformatted images.html and
security_center_auto_provisioning.html markdown, although I made no
changes there)

Fixes #9164

(make fmt reformatted images.html and
security_center_auto_provisioning.html markdown, although I made no
changes there)
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @favoretti

Thanks for this PR :)

Taking a look through this is looking good, if we can fix up the minor comments then this otherwise LGTM 👍

Thanks!

favoretti and others added 9 commits November 6, 2020 13:49
Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
…ool_data_source.go

Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for pushing those changes @favoretti

@tombuildsstuff tombuildsstuff added this to the v2.36.0 milestone Nov 9, 2020
@tombuildsstuff
Copy link
Member

@favoretti looks like the PPG ID test fails due to an invalid config?

------- Stdout: -------
=== RUN   TestAccAzureRMKubernetesClusterNodePool_proximityPlacementGroupId
=== PAUSE TestAccAzureRMKubernetesClusterNodePool_proximityPlacementGroupId
=== CONT  TestAccAzureRMKubernetesClusterNodePool_proximityPlacementGroupId
TestAccAzureRMKubernetesClusterNodePool_proximityPlacementGroupId: testing.go:684: Step 0 error: config is invalid: Unsupported argument: An argument named "proximity_placement_group_id" is not expected here.
--- FAIL: TestAccAzureRMKubernetesClusterNodePool_proximityPlacementGroupId (0.22s)
FAIL

@favoretti
Copy link
Collaborator Author

Ugh. I'll look into it in a bit and run acceptance here first too.

@favoretti
Copy link
Collaborator Author

$ TF_ACC=1 go test -v ./azurerm/internal/services/containers/tests/ -timeout=1000m -run TestAccAzureRMKubernetesClusterNodePool_proximityPlacementGroupId
=== RUN   TestAccAzureRMKubernetesClusterNodePool_proximityPlacementGroupId
=== PAUSE TestAccAzureRMKubernetesClusterNodePool_proximityPlacementGroupId
=== CONT  TestAccAzureRMKubernetesClusterNodePool_proximityPlacementGroupId
--- PASS: TestAccAzureRMKubernetesClusterNodePool_proximityPlacementGroupId (1184.41s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/containers/tests	1185.558s

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for pushing those changes @favoretti

@tombuildsstuff tombuildsstuff merged commit 6b1ed9f into hashicorp:master Nov 12, 2020
@tombuildsstuff
Copy link
Member

Tests look good 👍

tombuildsstuff added a commit that referenced this pull request Nov 12, 2020
@ghost
Copy link

ghost commented Nov 12, 2020

This has been released in version 2.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.36.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Dec 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for proxiomity groups in azurerm_kubernetes_cluster
2 participants