Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes_cluster: http_application_routing ForceNew removed #9358

Merged

Conversation

aristosvo
Copy link
Collaborator

@aristosvo aristosvo commented Nov 17, 2020

Implementation

Fixes #9367

Changes:

  • Removal of ForceNew from http_application_routing
  • Change of addonProfileRouting test to addonProfileRoutingToggle to test both enabling and disabling http_application_routing
  • Disabled addon_profile.0.kube_dashboard explicitly to let the test succeed

Acceptance Tests

=== RUN   TestAccAzureRMKubernetesCluster_addonProfileRoutingToggle
=== PAUSE TestAccAzureRMKubernetesCluster_addonProfileRoutingToggle
=== CONT  TestAccAzureRMKubernetesCluster_addonProfileRoutingToggle
--- PASS: TestAccAzureRMKubernetesCluster_addonProfileRoutingToggle (767.66s)

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @aristosvo

@tombuildsstuff tombuildsstuff added this to the v2.37.0 milestone Nov 18, 2020
@tombuildsstuff tombuildsstuff merged commit c17da92 into hashicorp:master Nov 18, 2020
tombuildsstuff added a commit that referenced this pull request Nov 18, 2020
@aristosvo aristosvo deleted the aks-http-application-route-optional branch November 18, 2020 18:53
@ghost
Copy link

ghost commented Nov 20, 2020

This has been released in version 2.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.37.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Dec 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked as resolved and limited conversation to collaborators Dec 19, 2020
@aristosvo aristosvo restored the aks-http-application-route-optional branch April 14, 2023 07:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for disabling add-on http_application_routing on kubernetes_cluster
2 participants